Message-ID: <555A2DA1.1000802@plumgrid.com>
Date: Mon, 18 May 2015 11:21:21 -0700
From: Alexei Starovoitov <ast@plumgrid.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Wang Nan <wangnan0@huawei.com>, paulus@samba.org, a.p.zijlstra@chello.nl,
        mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
        jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net,
        brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com
CC: lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [RFC PATCH v3 11/37] bpf tools: Iterate over ELF sections to
 collect information
References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-12-git-send-email-wangnan0@huawei.com>
In-Reply-To: <1431860222-61636-12-git-send-email-wangnan0@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 758
Lines: 20

On 5/17/15 3:56 AM, Wang Nan wrote:
> bpf_obj_elf_collect() is introduced to iterate over each elf sections
> to collection informations in eBPF object files. This function will
> futher enhanced to collect license, kernel version, programs, configs
> and map information.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
...
> +		if (gelf_getshdr(scn, &sh) != &sh) {
> +			pr_warning("failed to get section header"
> +				   " from %s\n", obj->path);

please don't wrap strings.
Here and in all other patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/