Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754626AbbERSfX (ORCPT ); Mon, 18 May 2015 14:35:23 -0400 Received: from mail-wg0-f68.google.com ([74.125.82.68]:34914 "EHLO mail-wg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754552AbbERSfS (ORCPT ); Mon, 18 May 2015 14:35:18 -0400 From: Adrian Remonda Cc: Adrian Remonda , Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , Julia Lawall , Joe Perches , Greg Donald , Melike Yurtoglu , Tristan Lelong , Omar Sandoval , HPDD-discuss@ml01.01.org (moderated list:STAGING - LUSTRE...), devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/4] Staging: lustre: sparse static warning fix Date: Mon, 18 May 2015 20:34:49 +0200 Message-Id: <1431974091-26363-3-git-send-email-adrianremonda@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431974091-26363-2-git-send-email-adrianremonda@gmail.com> References: <1431974091-26363-1-git-send-email-adrianremonda@gmail.com> <1431974091-26363-2-git-send-email-adrianremonda@gmail.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1966 Lines: 55 This patch clears the warning given by sparse that the function should be static. Done by moving the declaration of the structure 'nrs_core' into the header 'ptlrpc_internal.h' modified: drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c modified: drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h Signed-off-by: Adrian Remonda --- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 ------ drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 7 +++++++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c index aeceef5152ac..300310e064f5 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c @@ -417,12 +417,6 @@ ptlrpc_lprocfs_threads_max_seq_write(struct file *file, LPROC_SEQ_FOPS(ptlrpc_lprocfs_threads_max); /** - * \addtogoup nrs - * @{ - */ -extern struct nrs_core nrs_core; - -/** * Translates \e ptlrpc_nrs_pol_state values to human-readable strings. * * \param[in] state The policy state diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h index e07e2aacc62c..f9bfcff2ac9b 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h +++ b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h @@ -313,4 +313,11 @@ static inline void ptlrpc_reqset_put(struct ptlrpc_request_set *set) /* ptlrpc/nrs_fifo.c */ extern struct ptlrpc_nrs_pol_conf nrs_conf_fifo; +/** + * \addtogoup nrs + * @{ + */ +extern struct nrs_core nrs_core; + + #endif /* PTLRPC_INTERNAL_H */ -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/