Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754666AbbERSlt (ORCPT ); Mon, 18 May 2015 14:41:49 -0400 Received: from g4t3425.houston.hp.com ([15.201.208.53]:22429 "EHLO g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbbERSlq (ORCPT ); Mon, 18 May 2015 14:41:46 -0400 Message-ID: <555A3264.3060205@hp.com> Date: Mon, 18 May 2015 11:41:40 -0700 From: Rick Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Eric B Munson , David Miller CC: Eric Dumazet , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] tcp: Return error instead of partial read for saved syn headers References: <1431974158-28288-1-git-send-email-emunson@akamai.com> In-Reply-To: <1431974158-28288-1-git-send-email-emunson@akamai.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 17 On 05/18/2015 11:35 AM, Eric B Munson wrote: > Currently the getsockopt() requesting the cached contents of the syn > packet headers will fail silently if the caller uses a buffer that is > too small to contain the requested data. Rather than fail silently and > discard the headers, getsockopt() should return an error and report the > required size to hold the data. Is there any chapter and verse on whether a "failed" getsockopt() may alter the items passed to it? rick jones -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/