Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932806AbbERU2J (ORCPT ); Mon, 18 May 2015 16:28:09 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:34043 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932410AbbERU2H (ORCPT ); Mon, 18 May 2015 16:28:07 -0400 Date: Mon, 18 May 2015 16:28:03 -0400 From: Tejun Heo To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7 V2] workqueue: introduce get_pwq_unlocked() Message-ID: <20150518202803.GD24861@htj.duckdns.org> References: <1431433955-3173-1-git-send-email-laijs@cn.fujitsu.com> <1431433955-3173-4-git-send-email-laijs@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431433955-3173-4-git-send-email-laijs@cn.fujitsu.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 44 Hello, Lai. On Tue, May 12, 2015 at 08:32:31PM +0800, Lai Jiangshan wrote: > attrs management code may reuse existed pwq and it has open code existing > to do "lock();get_pwq();unlock()", we move this open code into > get_pwq_unlocked(). > > get_pwq_unlocked() will also be used in later patches to allow > apply_wqattrs_prepare() to resue the original default or per-node pwq. > > Signed-off-by: Lai Jiangshan ... > +install: > /* Install the new pwq. */ > mutex_lock(&wq->mutex); > old_pwq = numa_pwq_tbl_install(wq, node, pwq); > - goto out_unlock; > - > -use_dfl_pwq: > - mutex_lock(&wq->mutex); > - spin_lock_irq(&wq->dfl_pwq->pool->lock); > - get_pwq(wq->dfl_pwq); > - spin_unlock_irq(&wq->dfl_pwq->pool->lock); > - old_pwq = numa_pwq_tbl_install(wq, node, wq->dfl_pwq); > -out_unlock: > mutex_unlock(&wq->mutex); > put_pwq_unlocked(old_pwq); > } This doens't strike me as better. If we have other places where the unlocked get is used, maybe, but that's not the case. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/