Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932881AbbERUfa (ORCPT ); Mon, 18 May 2015 16:35:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:35122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932404AbbERUf2 (ORCPT ); Mon, 18 May 2015 16:35:28 -0400 Date: Mon, 18 May 2015 17:35:24 -0300 From: Arnaldo Carvalho de Melo To: Alexei Starovoitov Cc: Wang Nan , paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 19/37] bpf tools: Clear libelf and ELF parsing resrouce to finish opening Message-ID: <20150518203524.GG18563@kernel.org> References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-20-git-send-email-wangnan0@huawei.com> <555A3117.2000708@plumgrid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555A3117.2000708@plumgrid.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 37 Em Mon, May 18, 2015 at 11:36:07AM -0700, Alexei Starovoitov escreveu: > On 5/17/15 3:56 AM, Wang Nan wrote: > >After all eBPF programs in an object file are loaded, related ELF > >information is useless. Close the object file and free those memory. > > > >Signed-off-by: Wang Nan > >--- > > tools/lib/bpf/libbpf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > >index ded96cb..9ed8cca 100644 > >--- a/tools/lib/bpf/libbpf.c > >+++ b/tools/lib/bpf/libbpf.c > >@@ -687,8 +687,8 @@ struct bpf_object *bpf_open_object(const char *path) > > if (bpf_obj_validate(obj)) > > goto out; > > > >+ bpf_obj_clear_elf(obj); > > return obj; > >- > > out: > > bpf_close_object(obj); > > return NULL; > > > > looks like a bug in some previous patch in the same set. > Should be squashed with that patch? Right, please don't introduce bugs + fixes, we love bisecting :-) - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/