Date: Mon, 18 May 2015 16:38:09 -0400
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7 V2] workqueue: reuse the current default pwq when its
 attrs unchanged
Message-ID: <20150518203809.GF24861@htj.duckdns.org>
References: <1431433955-3173-1-git-send-email-laijs@cn.fujitsu.com>
 <1431433955-3173-6-git-send-email-laijs@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431433955-3173-6-git-send-email-laijs@cn.fujitsu.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 870
Lines: 24

Hello,

On Tue, May 12, 2015 at 08:32:33PM +0800, Lai Jiangshan wrote:
> When apply_wqattrs_prepare() is called, it is possible that the default
> pwq is unaffected.  It is always true that only the NUMA affinity is being
> changed and sometimes true that the low level cpumask is being changed.
> 
> So we try to reuse the current default pwq when its attrs unchanged.
> 
> After this change, "ctx->dfl_pwq->refcnt++" could be dangerous
> when ctx->dfl_pwq is being reused, so we use get_pwq_unlocked() instead.

Can you elaborate the above paragraph?  Why wouldn't that be dangerous
before this change?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/