Message-ID: <555A541F.6090606@plumgrid.com>
Date: Mon, 18 May 2015 14:05:35 -0700
From: Alexei Starovoitov <ast@plumgrid.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Wang Nan <wangnan0@huawei.com>, paulus@samba.org, a.p.zijlstra@chello.nl,
        mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org,
        dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com,
        masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com,
        linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [RFC PATCH v3 00/37] perf tools: introduce 'perf bpf' command
 to load eBPF programs.
References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <555A3FC2.8060805@plumgrid.com> <20150518204416.GJ18563@kernel.org>
In-Reply-To: <20150518204416.GJ18563@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 952
Lines: 24

On 5/18/15 1:44 PM, Arnaldo Carvalho de Melo wrote:
>
> perf record --filter, to pass a filter to tracepoints, if I could
> instead of a filter expression pass, say, filter_bpf.o, that would seem
> natural for me, i.e. no new option, just an alternative type of filter,
> one way more powerful.
...
> I'd say keep it in --filter, that noticing it is a bpf object would
> dtrt:
>
>    perf record --filter bpf_thing.o usleep 1
>

agree. make sense.
The only thing is that such bpf program defines both event and filter.
Existing --filter applies to --event, whereas this bpf_thing.o does both
and likely kprob-ing multiple events underneath.
I guess '--filter' still fits. Just need to document it clearly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/