Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989AbbERWq0 (ORCPT ); Mon, 18 May 2015 18:46:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54463 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754349AbbERWqZ (ORCPT ); Mon, 18 May 2015 18:46:25 -0400 Date: Mon, 18 May 2015 15:46:24 -0700 From: Greg KH To: Arthur Demchenkov Cc: abrestic@chromium.org, mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: make module xhci_hcd removable Message-ID: <20150518224624.GC18441@kroah.com> References: <1431971590-4031-1-git-send-email-spinal.by@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431971590-4031-1-git-send-email-spinal.by@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 17 On Mon, May 18, 2015 at 08:53:10PM +0300, Arthur Demchenkov wrote: > Fixed regression. After commit 29e409f the module xhci_hcd became > non-removable. That behaviour is not expected and there're no notes > about it in commit message. The module should be removable as it > blocks PM suspend/resume functions (Debian Bug#666406). I hate to ask why debian things that unloading all kernel modules is the correct thing to do for suspend... But that's separate from this patch, this looks correct, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/