Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932346AbbERXwe (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 May 2015 19:52:34 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:33377 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755045AbbERXwd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 May 2015 19:52:33 -0400
Date: Mon, 18 May 2015 19:52:30 -0400 (EDT)
Message-Id: <20150518.195230.2247842502863025488.davem@davemloft.net>
To: ddaney@caviumnetworks.com
Cc: aleksey.makarov@auriga.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, david.daney@cavium.com,
        sgoutham@cavium.com, mjc@semihalf.com,
        ganapatrao.kulkarni@caviumnetworks.com, tomasz.nowicki@linaro.org,
        rrichter@cavium.com, kamil@semihalf.com,
        tsrinivasulu@caviumnetworks.com, svangala@cavium.com, rric@kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 2/2] net: Adding support for Cavium
 ThunderX network controller
From: David Miller <davem@davemloft.net>
In-Reply-To: <555A5F1E.1010509@caviumnetworks.com>
References: <1431747401-20847-3-git-send-email-aleksey.makarov@auriga.com>
	<20150518.160931.2235555994068443513.davem@davemloft.net>
	<555A5F1E.1010509@caviumnetworks.com>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 May 2015 16:52:32 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 724
Lines: 23

From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 18 May 2015 14:52:30 -0700

> As I see it there are two options:
> 
> 1) Keep the writeq_relaxed()/readq_relaxed(), but add a comment about
> why they are safe.
> 
> 2) Change the patch so that we are using writeq()/readq() and suffer a
> decrease in performance.

I want a detailed comment added, so #1 would be my choice.

There are more than one set of register accessors, so make sure you
annotate them all.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/