Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbbESFUl (ORCPT ); Tue, 19 May 2015 01:20:41 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37059 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbbESFUj (ORCPT ); Tue, 19 May 2015 01:20:39 -0400 MIME-Version: 1.0 X-Originating-IP: [212.25.79.130] In-Reply-To: <20150518152723.769799cced031e71582bfa74@linux-foundation.org> References: <1431974526-21788-1-git-send-email-leon@leon.nu> <20150518152723.769799cced031e71582bfa74@linux-foundation.org> From: Leon Romanovsky Date: Tue, 19 May 2015 08:20:12 +0300 Message-ID: Subject: Re: [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel() To: Andrew Morton Cc: dhowells , aarcange , Linux-MM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1609 Lines: 42 On Tue, May 19, 2015 at 1:27 AM, Andrew Morton wrote: > On Mon, 18 May 2015 21:42:06 +0300 Leon Romanovsky wrote: > >> kenter/kleave/kdebug are wrapper macros to print functions flow and debug >> information. This set was written before pr_devel() was introduced, so >> it was controlled by "#if 0" construction. >> >> This patch refactors the current macros to use general pr_devel() >> functions which won't be compiled in if "#define DEBUG" is not declared >> prior to that macros. > > I doubt if anyone has used these in a decade and only a tenth of the > mm/nommu.c code is actually wired up to use the macros. A couple of days before, the question "how to handle such code" [1] was raised by me. Later, Joe Perches suggested to add into consideration the "delete option" [2]. > I'd suggest just removing it all. If someone later has a need, they > can add their own pr_devel() calls. My patch followed the preference of initial author (David Howells [3] and [4]). Please advise how should I proceed with it. [1] [RFC] Refactor kenter/kleave/kdebug macros - https://lkml.org/lkml/2015/5/16/279 [2] https://lkml.org/lkml/2015/5/16/280 [3] https://lkml.org/lkml/2015/5/18/199 [4] https://lkml.org/lkml/2015/5/18/457 Thanks. -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@leon.nu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/