Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbbESFY2 (ORCPT ); Tue, 19 May 2015 01:24:28 -0400 Received: from canardo.mork.no ([148.122.252.1]:44316 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbbESFY0 convert rfc822-to-8bit (ORCPT ); Tue, 19 May 2015 01:24:26 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Greg KH Cc: Arthur Demchenkov , abrestic@chromium.org, mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: make module xhci_hcd removable Organization: m References: <1431971590-4031-1-git-send-email-spinal.by@gmail.com> <20150518224624.GC18441@kroah.com> Date: Tue, 19 May 2015 07:24:15 +0200 In-Reply-To: <20150518224624.GC18441@kroah.com> (Greg KH's message of "Mon, 18 May 2015 15:46:24 -0700") Message-ID: <87lhglrvgg.fsf@nemi.mork.no> User-Agent: Gnus/5.130013 (Ma Gnus v0.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (canardo.mork.no [IPv6:2001:4641::1]); Tue, 19 May 2015 07:24:16 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 24 Greg KH writes: > On Mon, May 18, 2015 at 08:53:10PM +0300, Arthur Demchenkov wrote: >> Fixed regression. After commit 29e409f the module xhci_hcd became >> non-removable. That behaviour is not expected and there're no notes >> about it in commit message. The module should be removable as it >> blocks PM suspend/resume functions (Debian Bug#666406). > > I hate to ask why debian things that unloading all kernel modules is the > correct thing to do for suspend... They don't. If you look closer, the bug report refers to unloading xhci_hcd as a *workaround* for the bug which casued xhci_hcd to immediately wake the system. But I was under the impression that (other) bug was fixed long ago? Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/