Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbbESF1v (ORCPT ); Tue, 19 May 2015 01:27:51 -0400 Received: from mail.kernel.org ([198.145.29.136]:53719 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbESF1r (ORCPT ); Tue, 19 May 2015 01:27:47 -0400 Date: Tue, 19 May 2015 13:27:16 +0800 From: Shawn Guo To: Philippe Reynes Cc: shawn.guo@linaro.org, kernel@pengutronix.de, linux@arm.linux.org.uk, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, fabio.estevam@freescale.com Subject: Re: [PATCH 1/2] rtc: mxc: add a second clock Message-ID: <20150519052716.GO1071@dragon> References: <1431729330-7625-1-git-send-email-tremyfr@gmail.com> <1431729330-7625-2-git-send-email-tremyfr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431729330-7625-2-git-send-email-tremyfr@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3837 Lines: 109 On Sat, May 16, 2015 at 12:35:29AM +0200, Philippe Reynes wrote: > The mxc RTC needs two clocks, one for the input > reference, and one for the IP. But this driver > was only using one clock (for the reference). > This patch add the second clock (for the IP). > > Signed-off-by: Philippe Reynes > --- > arch/arm/mach-imx/clk-imx31.c | 3 ++- We're moving the clock driver into drivers/clk/imx folder during this development cycle. I suggest you patch the file from there, and update driver code in the next development cycle. Shawn > drivers/rtc/rtc-mxc.c | 26 +++++++++++++++++--------- > 2 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/mach-imx/clk-imx31.c b/arch/arm/mach-imx/clk-imx31.c > index 286ef42..480c54f 100644 > --- a/arch/arm/mach-imx/clk-imx31.c > +++ b/arch/arm/mach-imx/clk-imx31.c > @@ -130,7 +130,8 @@ int __init mx31_clocks_init(unsigned long fref) > clk_register_clkdev(clk[cspi3_gate], NULL, "imx31-cspi.2"); > clk_register_clkdev(clk[pwm_gate], "pwm", NULL); > clk_register_clkdev(clk[wdog_gate], NULL, "imx2-wdt.0"); > - clk_register_clkdev(clk[rtc_gate], NULL, "imx21-rtc"); > + clk_register_clkdev(clk[ckil], "rtc", "imx21-rtc"); > + clk_register_clkdev(clk[rtc_gate], "ipg", "imx21-rtc"); > clk_register_clkdev(clk[epit1_gate], "epit", NULL); > clk_register_clkdev(clk[epit2_gate], "epit", NULL); > clk_register_clkdev(clk[nfc], NULL, "imx27-nand.0"); > diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c > index 09d422b..e916a91 100644 > --- a/drivers/rtc/rtc-mxc.c > +++ b/drivers/rtc/rtc-mxc.c > @@ -79,7 +79,8 @@ struct rtc_plat_data { > struct rtc_device *rtc; > void __iomem *ioaddr; > int irq; > - struct clk *clk; > + struct clk *clk_rtc; > + struct clk *clk_ipg; > struct rtc_time g_rtc_alarm; > enum imx_rtc_type devtype; > }; > @@ -373,17 +374,24 @@ static int mxc_rtc_probe(struct platform_device *pdev) > if (IS_ERR(pdata->ioaddr)) > return PTR_ERR(pdata->ioaddr); > > - pdata->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(pdata->clk)) { > - dev_err(&pdev->dev, "unable to get clock!\n"); > - return PTR_ERR(pdata->clk); > + pdata->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > + if (IS_ERR(pdata->clk_ipg)) { > + dev_err(&pdev->dev, "unable to get ipg clock!\n"); > + return PTR_ERR(pdata->clk_ipg); > } > > - ret = clk_prepare_enable(pdata->clk); > + ret = clk_prepare_enable(pdata->clk_ipg); > if (ret) > return ret; > > - rate = clk_get_rate(pdata->clk); > + pdata->clk_rtc = devm_clk_get(&pdev->dev, "rtc"); > + if (IS_ERR(pdata->clk_rtc)) { > + dev_err(&pdev->dev, "unable to get rtc clock!\n"); > + ret = PTR_ERR(pdata->clk_rtc); > + goto exit_put_clk; > + } > + > + rate = clk_get_rate(pdata->clk_rtc); > > if (rate == 32768) > reg = RTC_INPUT_CLK_32768HZ; > @@ -432,7 +440,7 @@ static int mxc_rtc_probe(struct platform_device *pdev) > return 0; > > exit_put_clk: > - clk_disable_unprepare(pdata->clk); > + clk_disable_unprepare(pdata->clk_ipg); > > return ret; > } > @@ -441,7 +449,7 @@ static int mxc_rtc_remove(struct platform_device *pdev) > { > struct rtc_plat_data *pdata = platform_get_drvdata(pdev); > > - clk_disable_unprepare(pdata->clk); > + clk_disable_unprepare(pdata->clk_ipg); > > return 0; > } > -- > 1.7.4.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/