Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbbESGPm (ORCPT ); Tue, 19 May 2015 02:15:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33812 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753870AbbESGPh (ORCPT ); Tue, 19 May 2015 02:15:37 -0400 Date: Tue, 19 May 2015 08:15:32 +0200 Message-ID: From: Takashi Iwai To: Jonathan McDowell Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 In-Reply-To: <20150502150513.GF10148@earth.li> References: <20150428112156.GQ10148@earth.li> <20150428123518.GU10148@earth.li> <20150429112859.GY10148@earth.li> <20150430150131.GA10148@earth.li> <20150502150513.GF10148@earth.li> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2200 Lines: 62 At Sat, 2 May 2015 16:05:13 +0100, Jonathan McDowell wrote: > > On Thu, Apr 30, 2015 at 07:06:31PM +0200, Takashi Iwai wrote: > > At Thu, 30 Apr 2015 16:01:31 +0100, Jonathan McDowell wrote: > > > > > > On Wed, Apr 29, 2015 at 01:54:57PM +0200, Takashi Iwai wrote: > > > > > > > > One patch you can try (with or without power_save_node > > > > disablement) is below, it squashes the verb sequences at (runtime) > > > > PM resume as we did for 4.0. Let me know if this changes the > > > > behavior. > > > > > > Patch alone has no effect. Patch with power_save_node disablement > > > solves the problem. Didn't try power_save_node disablement without > > > the patch. > > > > Then please confirm that only power_save_node disablement suffices. > > This can be considered as the least change that can be put to 4.1-rc > > if no better fix is found. > > Setting codec->power_save_node to 0 in patch_alc269 is sufficient; no > noticeable cracking occurring. Does the patch below have any improvement? Takashi --- diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 788f969b1a68..17147c2638f3 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -841,11 +841,19 @@ static hda_nid_t path_power_update(struct hda_codec *codec, else state = AC_PWRST_D3; if (!snd_hda_check_power_state(codec, nid, state)) { - snd_hda_codec_write(codec, nid, 0, + snd_hda_codec_read(codec, nid, 0, AC_VERB_SET_POWER_STATE, state); changed = nid; - if (state == AC_PWRST_D0) - snd_hdac_regmap_sync_node(&codec->core, nid); + if (state == AC_PWRST_D0) { + msleep(10); + /* all known codecs seem to be capable to handle + * widgets state even in D3, so far. + * if any new codecs need to restore the widget + * states after D0 transition, call the function + * below. + */ + /* snd_hdac_regmap_sync_node(&codec->core, nid); */ + } } } return changed; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/