Date: Tue, 19 May 2015 16:44:30 +0900
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
        Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 1/3] mm/page_alloc: don't break highest order freepage if
 steal
Message-ID: <20150519074429.GC12092@js1304-P5Q-DELUXE>
References: <1430119421-13536-1-git-send-email-iamjoonsoo.kim@lge.com>
 <5551B11C.4080000@suse.cz>
 <5551B1CB.7070301@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5551B1CB.7070301@suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1014
Lines: 33

On Tue, May 12, 2015 at 09:54:51AM +0200, Vlastimil Babka wrote:
> On 05/12/2015 09:51 AM, Vlastimil Babka wrote:
> >>   {
> >>   	struct page *page;
> >>+	bool steal_fallback;
> >>
> >>-retry_reserve:
> >>+retry:
> >>   	page = __rmqueue_smallest(zone, order, migratetype);
> >>
> >>   	if (unlikely(!page) && migratetype != MIGRATE_RESERVE) {
> >>   		if (migratetype == MIGRATE_MOVABLE)
> >>   			page = __rmqueue_cma_fallback(zone, order);
> >>
> >>-		if (!page)
> >>-			page = __rmqueue_fallback(zone, order, migratetype);
> >>+		if (page)
> >>+			goto out;
> >>+
> >>+		steal_fallback = __rmqueue_fallback(zone, order, migratetype);
> 
> Oh and the variable can be probably replaced by calling
> __rmqueue_fallback directly in the if() below.

Will do.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/