Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbbESIQY (ORCPT ); Tue, 19 May 2015 04:16:24 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:36083 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886AbbESIQJ (ORCPT ); Tue, 19 May 2015 04:16:09 -0400 Message-ID: <555AF143.2060807@linaro.org> Date: Tue, 19 May 2015 10:16:03 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Maxime Coquelin CC: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Joe Perches , Vladimir Zapolskiy , Lee Jones , Daniel Thompson , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Subject: Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-10-git-send-email-mcoquelin.stm32@gmail.com> <5559E4B0.70506@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2563 Lines: 65 On 05/18/2015 04:03 PM, Maxime Coquelin wrote: > 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : >> On 05/09/2015 09:53 AM, Maxime Coquelin wrote: >>> >>> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >>> The drivers detects whether the time is 16 or 32 bits, and applies a >>> 1024 prescaler value if it is 16 bits. >>> >>> Reviewed-by: Linus Walleij >>> Tested-by: Chanwoo Choi >>> Signed-off-by: Maxime Coquelin >>> --- >>> drivers/clocksource/Kconfig | 8 ++ >>> drivers/clocksource/Makefile | 1 + >>> drivers/clocksource/timer-stm32.c | 184 >>> ++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 193 insertions(+) >>> create mode 100644 drivers/clocksource/timer-stm32.c >>> >>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >>> index bf9364c..2443520 100644 >>> --- a/drivers/clocksource/Kconfig >>> +++ b/drivers/clocksource/Kconfig >>> @@ -106,6 +106,14 @@ config CLKSRC_EFM32 >>> Support to use the timers of EFM32 SoCs as clock source and >>> clock >>> event device. >>> >>> +config CLKSRC_STM32 >>> + bool "Clocksource for STM32 SoCs" if !ARCH_STM32 >>> + depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) >> >> >> Are the interactive bool and the 'COMPILE_TEST' necessary ? >> > > The interactive bool is necessary if we want to be able to > select/deselect it in COMPILE_TEST configuration. > And personnaly, I think COMPILE_TEST use makes sense. > > Note that other timer drivers are doing the same thing today > (CLKSRC_EFM32, SH_TIMER_CMT, EM_TIMER_STI...). > > Do you have a specific concern regarding COMPILE_TEST? Actually, we try to keep the timer selection non-interactive and let the platform's Kconfig to select the timer. I like when the code is consistent. The COMPILE_TEST was introduced and created a precedence. I would like to get rid of the interactive timer selection but I did not have time to go through this yet. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/