Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbbESIcH (ORCPT ); Tue, 19 May 2015 04:32:07 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56998 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbbESIcC (ORCPT ); Tue, 19 May 2015 04:32:02 -0400 Date: Tue, 19 May 2015 01:32:00 -0700 From: Christoph Hellwig To: Mike Snitzer Cc: Christoph Hellwig , Jens Axboe , dm-devel@redhat.com, Joe Thornber , linux-kernel@vger.kernel.org Subject: Re: [PATCH for-4.2 04/14] block: factor out blkdev_issue_discard_async Message-ID: <20150519083200.GA31648@infradead.org> References: <1431637512-64245-1-git-send-email-snitzer@redhat.com> <1431637512-64245-5-git-send-email-snitzer@redhat.com> <20150518082756.GB5439@infradead.org> <20150518133223.GC13998@redhat.com> <20150518161721.GA28385@infradead.org> <20150518191830.GA15656@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150518191830.GA15656@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 21 On Mon, May 18, 2015 at 03:18:30PM -0400, Mike Snitzer wrote: > > And besides that generic high level sentiment I think the interface > > for blkdev_issue_discard_async is simply wrong. Either you want to keep > > the internals private and just expose a completion callback that gets > > your private data and an error, or you want to build your own bios as > > suggested above. But not one that is mostly opaque except for allowing > > the caller to hook into the submission process and thus taking over I/O > > completion. > > I'll see what I can come up with. Another option would be to help with reviewing and testing this series: http://thread.gmane.org/gmane.linux.kernel/1947453 If we can get thast one in the submitter doesn't have to care about aligning or splitting discard (or any other) bios. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/