Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932537AbbESJrO (ORCPT ); Tue, 19 May 2015 05:47:14 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:45727 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbbESJrA (ORCPT ); Tue, 19 May 2015 05:47:00 -0400 Message-ID: <1432028814.9091.68.camel@x220> Subject: Re: [PATCH 3/3] init: Set initcall_debug to a default value From: Paul Bolle To: Iulia Manda Cc: tim.bird@sonymobile.com, linux-kernel@vger.kernel.org, josh@joshtriplett.org Date: Tue, 19 May 2015 11:46:54 +0200 In-Reply-To: <1431949832-13606-3-git-send-email-iulia.manda21@gmail.com> References: <1431949832-13606-1-git-send-email-iulia.manda21@gmail.com> <1431949832-13606-3-git-send-email-iulia.manda21@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 57 On Mon, 2015-05-18 at 14:50 +0300, Iulia Manda wrote: > Test the previously implemented macros on initcall_debug parameter, after > setting CONFIG_CMDLINE_PARSE to 'n'. > > This change is a first example for how knowing the values of kernel > parameters at build time can allow GCC constant folding and result in an > actually relevant decrease in size. Other types of parameters also need to > be handled. Also, at the moment this would only work with default values. > For being able to change those defaults and still know their values at > compile time, a pre-compiled stand-alone parser should be run on those > variables. This will be discussed in a following patch. > > The variable corresponding to initcall_debug kernel parameter is set by > default to false. Even though DEFINE_CORE_PARAM resumes to nothing when resumes to nothing? > CONFIG_CMDLINE_PARSE is not set, we need to use it in main.c so that it is > still defined when this option is 'y'. > --- > include/linux/init.h | 3 ++- > init/main.c | 3 +-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/init.h b/include/linux/init.h > index 21b6d76..7c7ee80 100644 > --- a/include/linux/init.h > +++ b/include/linux/init.h > -extern bool initcall_debug; > +DECLARE_CORE_PARAM(initcall_debug, false, bool); CONFIG_CMDLINE_PARSE will never be set outside of x86, right? So does this change nothing for those other architectures? > #endif > > diff --git a/init/main.c b/init/main.c > index 2115055..a7d0129 100644 > -bool initcall_debug; > -core_param(initcall_debug, initcall_debug, bool, 0644); > +DEFINE_CORE_PARAM(initcall_debug, initcall_debug, false, bool, 0644); Ditto. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/