Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755060AbbESKSw (ORCPT ); Tue, 19 May 2015 06:18:52 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.141]:11699 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbbESKSs convert rfc822-to-8bit (ORCPT ); Tue, 19 May 2015 06:18:48 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-7.tower-178.messagelabs.com!1432030607!33181020!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.15; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Alexandre Belloni , Guenter Roeck CC: LINUXKERNEL , LINUXWATCHDOG , Wim Van Sebroeck , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , Lee Jones , Liam Girdwood , Mark Brown , "Mark Rutland" , Pawel Moll , RTCLINUX , Rob Herring , Samuel Ortiz , Support Opensource Subject: RE: [rtc-linux] RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver Thread-Topic: [rtc-linux] RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver Thread-Index: AQHQjmaAk/e82jzsZEKEpHYCwGOkXZ18O9SAgABrP6CAAEjcgIAAFECwgABnT4CABEJgUIAAIuiAgAAX5ACAAAzxgIABAlyA Date: Tue, 19 May 2015 10:16:46 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22B994@SW-EX-MBX02.diasemi.com> References: <6a51f163b99edfad9165ad29609abb072dbaa2b7.1431621833.git.stwiss.opensource@diasemi.com> <55555639.8090505@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B63A@SW-EX-MBX02.diasemi.com> <5555ED4F.5070003@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B6E2@SW-EX-MBX02.diasemi.com> <20150515202005.GA23133@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8@SW-EX-MBX02.diasemi.com> <20150518152737.GA14403@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B8FE@SW-EX-MBX02.diasemi.com> <20150518173927.GV3338@piout.net> In-Reply-To: <20150518173927.GV3338@piout.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 32 On 18 May 2015 18:39 Alexandre Belloni wrote: > Sure, what I understand is that the base functionality is the same and > even the registers are compatible. Are you sure the new features can't > be added to the da9063 and called conditionally? Plenty of drivers are > doing that. Hi Alexandre/Guenter, I didn't say it couldn't be added to DA9063. Of course it's all possible, but I think it would become unmaintainable in future without separate drivers. There is some extra freeze functionality and a watchdog warn interrupt: both do not exist in the DA9063. What I did say **one month ago** was the DA9062 watchdog driver does have some similarities with the DA9063 watchdog (https://lkml.org/lkml/2015/5/6/505). But I would prefer two drivers for watchdog in this case. When compared to the RTC and OnKey the watchdog is very different on the hardware side. Despite the appearance of some similarity, the watchdog is not a functional clone like the RTC and OnKey components. I would not like a combined watchdog driver because I think that the extra functions that the DA9062 contains would bloat out the DA9063 watchdog, and would make it difficult to test and to maintain for the future.. Regards, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/