Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbbESOli (ORCPT ); Tue, 19 May 2015 10:41:38 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:36719 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbbESOlg (ORCPT ); Tue, 19 May 2015 10:41:36 -0400 MIME-Version: 1.0 In-Reply-To: <1431878106-30579-11-git-send-email-ygardi@codeaurora.org> References: <1431878106-30579-1-git-send-email-ygardi@codeaurora.org> <1431878106-30579-11-git-send-email-ygardi@codeaurora.org> Date: Tue, 19 May 2015 23:41:33 +0900 Message-ID: Subject: Re: [PATCH v1 10/10] scsi: ufs-qcom: enable UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION From: Akinobu Mita To: Yaniv Gardi Cc: Jej B , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , dovl@codeaurora.org, Dolev Raviv , Vinayak Holikatti , "James E.J. Bottomley" , chuanxiao.dong@intel.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1468 Lines: 39 2015-05-18 0:55 GMT+09:00 Yaniv Gardi : > Newer revisions of QUALCOMM Technologies UFS host controller may not > advertise the correct version information in UFS HCI VER register. > To handle this, enable UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION to let > UFS standard host controller driver call into vendor specific > operation to get right UFS HCI VER register value. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index de9cfb0..4cdffa4 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -694,6 +694,16 @@ out: > return ret; > } > > +static u32 ufs_qcom_get_ufs_hci_version(struct ufs_hba *hba) > +{ > + struct ufs_qcom_host *host = hba->priv; > + > + if (host->hw_ver.major == 0x1) > + return UFSHCI_VERSION_11; > + else > + return UFSHCI_VERSION_20; Btw, UFS driver currently lacks UFSHCI 2.0 support. Shouldn't we also need a change like the patch submitted by Chuanxiao Dong: http://marc.info/?l=linux-scsi&m=140688020815020&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/