Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757165AbbESPc0 (ORCPT ); Tue, 19 May 2015 11:32:26 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:42655 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754122AbbESPcY (ORCPT ); Tue, 19 May 2015 11:32:24 -0400 From: Charles Keepax To: lee.jones@linaro.org Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH v2] mfd: arizona: Add missing braces Date: Tue, 19 May 2015 16:22:11 +0100 Message-Id: <1432048931-2287-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Mailer: git-send-email 1.7.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 48 Some braces were missing from commit 67f0b1133d55 ("mfd: arizona: Add better support for system suspend"). This will cause the error check to run even if the register write didn't happen (although ret will always be zero so it is harmless). This patch adds the missing braces. Reported-by: Dan Carpenter Signed-off-by: Charles Keepax --- Changes since v1: - Corrected braino in commit message (parenthesis -> braces) Thanks, Charles drivers/mfd/arizona-core.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 5caf579..bebf58a 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -626,7 +626,7 @@ static int arizona_runtime_suspend(struct device *dev) } break; case WM5102: - if (!(val & ARIZONA_JD1_ENA)) + if (!(val & ARIZONA_JD1_ENA)) { ret = regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_3, 0x0); if (ret) { @@ -635,6 +635,7 @@ static int arizona_runtime_suspend(struct device *dev) ret); return ret; } + } break; default: break; -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/