Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965027AbbESPXz (ORCPT ); Tue, 19 May 2015 11:23:55 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:42626 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932975AbbESPXx (ORCPT ); Tue, 19 May 2015 11:23:53 -0400 Date: Tue, 19 May 2015 16:23:51 +0100 From: Charles Keepax To: Richard Fitzgerald Cc: lee.jones@linaro.org, broonie@kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v6 1/1] mfd: arizona: Export functions to control subsystem DVFS Message-ID: <20150519152351.GA31187@opensource.wolfsonmicro.com> References: <1432047462-31860-1-git-send-email-rf@opensource.wolfsonmicro.com> <1432047462-31860-2-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432047462-31860-2-git-send-email-rf@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 32 On Tue, May 19, 2015 at 03:57:42PM +0100, Richard Fitzgerald wrote: > The WM5102, WM8997, WM8998 and WM1814 codecs have an internal dynamic > clock booster. When this booster is active, the DCVDD voltage must be > increased. If all the currently active audio paths can run with the root > SYSCLK we can disable the booster, allowing us to turn down DCVDD voltage > to save power. > > Previously this was being done by having the booster enable bit set > as a side-effect of the LDO1 regulator driver, which is unexpected > behaviour of a regulator and not compatible with using an external > regulator. > > This patch exports functions to handle the booster enable and > DCVDD voltage, with each relevant subsystem flagging whether it can > currently run without the booster. Note that these subsystems are > stateless and none of them are nestable, so there's no need for > reference counting, we only need a simple boolean for each subsystem > of whether their current condition could require the booster or will > allow us to turn the codec down to lower operating power. > > Signed-off-by: Richard Fitzgerald > --- Reviewed-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/