Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756628AbbESQUj (ORCPT ); Tue, 19 May 2015 12:20:39 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:38644 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756606AbbESQUg (ORCPT ); Tue, 19 May 2015 12:20:36 -0400 Date: Tue, 19 May 2015 11:20:03 -0500 From: Benoit Parrot To: Arnd Bergmann CC: , Mauro Carvalho Chehab , Hans Verkuil , , , Prabhakar , Sakari Ailus Subject: Re: [PATCH] [media] ov2659: add v4l2_subdev dependency Message-ID: <20150519162002.GE8123@ti.com> References: <6092911.yr0lA5IaG4@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6092911.yr0lA5IaG4@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2089 Lines: 44 Thanks, for the patch. Acked-by: Benoit Parrot Arnd Bergmann wrote on Tue [2015-May-19 14:39:12 +0200]: > The newly added ov2659 driver uses the v4l2 subdev API, but > can be enabled even when that API is not part of the kernel, > resulting in this build error: > > media/i2c/ov2659.c: In function 'ov2659_get_fmt': > media/i2c/ov2659.c:1054:8: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] > media/i2c/ov2659.c:1054:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > media/i2c/ov2659.c: In function 'ov2659_set_fmt': > media/i2c/ov2659.c:1129:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > media/i2c/ov2659.c: In function 'ov2659_open': > media/i2c/ov2659.c:1264:38: error: 'struct v4l2_subdev_fh' has no member named 'pad' > > This adds an explicit dependency, like all the other drivers have. > > Signed-off-by: Arnd Bergmann > Fixes: c4c0283ab3c ("[media] media: i2c: add support for omnivision's ov2659 sensor") > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 6f30ea76151a..db01ed84918f 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -469,7 +469,7 @@ config VIDEO_SMIAPP_PLL > config VIDEO_OV2659 > tristate "OmniVision OV2659 sensor support" > depends on VIDEO_V4L2 && I2C > - depends on MEDIA_CAMERA_SUPPORT > + depends on MEDIA_CAMERA_SUPPORT && VIDEO_V4L2_SUBDEV_API > ---help--- > This is a Video4Linux2 sensor-level driver for the OmniVision > OV2659 camera. > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/