Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbbESRRi (ORCPT ); Tue, 19 May 2015 13:17:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45543 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbbESRRd (ORCPT ); Tue, 19 May 2015 13:17:33 -0400 Date: Tue, 19 May 2015 10:17:32 -0700 From: Greg Kroah-Hartman To: Sudeep Holla Cc: Rob Herring , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "grant.likely@linaro.org" , Rob Herring , Pawel Moll , Benjamin Herrenschmidt Subject: Re: [PATCH v2] drivers: of/base: move of_init to driver_init Message-ID: <20150519171732.GD9213@kroah.com> References: <1431595695-17103-1-git-send-email-sudeep.holla@arm.com> <1431613704-30801-1-git-send-email-sudeep.holla@arm.com> <555B2C9C.1000709@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555B2C9C.1000709@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 35 On Tue, May 19, 2015 at 01:29:16PM +0100, Sudeep Holla wrote: > Hi Rob/Greg, > > On 14/05/15 15:28, Sudeep Holla wrote: > >Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from > >devices with an OF node") adds the symlink `of_node` for each device > >pointing to it's device tree node while creating/initialising it. > > > >However the devicetree sysfs is created and setup in of_init which is > >executed at core_initcall level. For all the devices created before > >of_init, the following error is thrown: > > "Error -2(-ENOENT) creating of_node link" > > > >Like many other components in driver model, initialize the sysfs support > >for OF/devicetree from driver_init so that it's ready before any devices > >are created. > > > >Fixes: 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from > > devices with an OF node") > >Suggested-by: Rob Herring > >Cc: Grant Likely > >Cc: Rob Herring > >Cc: Pawel Moll > >Cc: Benjamin Herrenschmidt > >Cc: Greg Kroah-Hartman > >Signed-off-by: Sudeep Holla > > I assume one of you will pick this up if there are no further comments ? I will once things settle down... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/