Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751818AbbESSpE (ORCPT ); Tue, 19 May 2015 14:45:04 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:34253 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbbESSpD (ORCPT ); Tue, 19 May 2015 14:45:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150519181334.GM4641@pd.tnic> References: <1432050210-32036-1-git-send-email-prarit@redhat.com> <20150519181334.GM4641@pd.tnic> From: Andy Lutomirski Date: Tue, 19 May 2015 11:44:41 -0700 Message-ID: Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup To: Borislav Petkov Cc: "linux-kernel@vger.kernel.org" , Fenghua Yu , Dave Hansen , Thomas Gleixner , Denys Vlasenko , Ingo Molnar , Brian Gerst , "H. Peter Anvin" , Igor Mammedov , "the arch/x86 maintainers" , Prarit Bhargava Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 19 On May 19, 2015 11:13 AM, "Borislav Petkov" wrote: > > On Tue, May 19, 2015 at 01:25:59PM -0400, Brian Gerst wrote: > > Using strlcpy in this manner could fail if it does larger than byte > > copies and they overlap. > > Why? > > AFAICT, strlcpy() calls memcpy() and memcpy should handle overlapping > buffers just fine. Are you thinking of memmove? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/