Message-ID: <1432062843.4510.159.camel@linux.vnet.ibm.com>
Subject: Re: [PATCH 10/8] modsign: Allow password to be specified for
 signing key
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>, rusty@rustcorp.com.au,
        mmarek@suse.cz, mjg59@srcf.ucam.org, keyrings@linux-nfs.org,
        dmitry.kasatkin@gmail.com, mcgrof@suse.com,
        linux-kernel@vger.kernel.org, seth.forshee@canonical.com,
        linux-security-module@vger.kernel.org
Date: Tue, 19 May 2015 15:14:03 -0400
In-Reply-To: <5444.1432061302@warthog.procyon.org.uk>
References: <1432060749.4510.155.camel@linux.vnet.ibm.com>
	 <20150515123513.16723.96340.stgit@warthog.procyon.org.uk>
	 <1432046758.3277.36.camel@infradead.org>
	 <5444.1432061302@warthog.procyon.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 697
Lines: 21

On Tue, 2015-05-19 at 19:48 +0100, David Howells wrote:
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> 
> > Definitely better.  (FYI, Dmitry's modsig patches from 2012 used the
> > keyring for safely storing a password. )

Without the environment variable set, there's a pop up prompt to enter
the pin.  A pain to have to enter for each and every kernel module, but
definitely a nice option.

> Can I add that as a reviewed-by for Dave?

Sure

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/