Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbbESTxR (ORCPT ); Tue, 19 May 2015 15:53:17 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:55788 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbbESTxP (ORCPT ); Tue, 19 May 2015 15:53:15 -0400 Date: Tue, 19 May 2015 22:53:05 +0300 From: Baruch Siach To: Javier Martinez Canillas Cc: Mark Brown , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Doug Anderson , linux-kernel@vger.kernel.org, Kukjin Kim , Olof Johansson , David Hendricks , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 1/4] spi: spidev: Add Google SPI flash compatible string Message-ID: <20150519195305.GA2586@tarshish> References: <1432042454-19234-1-git-send-email-javier.martinez@collabora.co.uk> <1432042454-19234-2-git-send-email-javier.martinez@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432042454-19234-2-git-send-email-javier.martinez@collabora.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 35 Hi Javier, On Tue, May 19, 2015 at 03:34:11PM +0200, Javier Martinez Canillas wrote: > Google Chromebooks have a SPI flash that is used to store firmware and > different system parameters and data (i.e: Google Binary Block flags). > > Since there isn't a driver for it yet, the spidev interface is used to > access the flash from user-space (i.e: using the flashrom tool). > > Add a "google,spi-flash" compatible string so the Device Tree sources > use it instead of the "spidev" compatible which does not describe the > real HW and is just a Linux implementation detail. > > A generic "google,spi-flash" OF device ID is used instead of the actual > vendor/model because these chips are commodity parts that are sourced > from multiple vendors. So specifying the exact vendor and model in the > DTS will add a maintenance burden with no real gain (the parts are 100% > compatible anyways) and will likely result in it simply being wrong for > a sizeable fraction of the machines. The compatible string and dt binding should be documented somewhere under Documentation/devicetree/bindings/. Also, please keep the dt list on Cc for dt related patches. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/