Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbbESUAv (ORCPT ); Tue, 19 May 2015 16:00:51 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57239 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbbESUAr (ORCPT ); Tue, 19 May 2015 16:00:47 -0400 Message-ID: <1432065634.3277.81.camel@infradead.org> Subject: Re: Should we automatically generate a module signing key at all? From: David Woodhouse To: Andy Lutomirski Cc: Linus Torvalds , Andy Lutomirski , David Howells , Michal Marek , Abelardo Ricart III , Linux Kernel Mailing List , Sedat Dilek , keyrings@linux-nfs.org, Rusty Russell , LSM List , Borislav Petkov , Jiri Kosina Date: Tue, 19 May 2015 21:00:34 +0100 In-Reply-To: References: <31154.1431965087@warthog.procyon.org.uk> <555A88FB.7000809@kernel.org> <1432058889.3277.73.camel@infradead.org> <1432060732.3277.77.camel@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 24 On Tue, 2015-05-19 at 11:49 -0700, Andy Lutomirski wrote: > > If we use hashes instead of signatures on in-tree modules (at least in > the case where no long-term key is provided), then generation of the > temporary signing key stops being an issue because there is no longer > a temporary signing key. With signatures I can make a one-line change to a module and rebuild it, and still load it without having to rebuild my vmlinux to 'permit' it. My signing key is valid for as long as I *choose* it to be valid. I appreciate why that's a problem in your scenario, but it's a valid and useful feature of signatures, and I don't think we can just abandon it. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/