Message-ID: <1432067319.2870.211.camel@perches.com>
Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup
From: Joe Perches <joe@perches.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Brian Gerst <brgerst@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Igor Mammedov <imammedo@redhat.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Prarit Bhargava <prarit@redhat.com>
Date: Tue, 19 May 2015 13:28:39 -0700
In-Reply-To: <1432067178.2870.209.camel@perches.com>
References: <1432050210-32036-1-git-send-email-prarit@redhat.com>
	 <CAMzpN2iJr7GVWm5peLxHvUc2geAgWVVqQ-q91SFEBy6LSuJZcA@mail.gmail.com>
	 <20150519181334.GM4641@pd.tnic>
	 <CALCETrWeQ3McFeyggvV8p+N76gB1-=gYm9SDS4x5RcPb0r_sEg@mail.gmail.com>
	 <20150519192206.GN4641@pd.tnic>
	 <CALCETrW2YxHeaejGOvpeG2rHwX9sbaw8hQ3xqZ+qRGPtpcuVpQ@mail.gmail.com>
	 <1432067178.2870.209.camel@perches.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1068
Lines: 29

On Tue, 2015-05-19 at 13:26 -0700, Joe Perches wrote:
> iOn Tue, 2015-05-19 at 13:16 -0700, Andy Lutomirski wrote:
> > On Tue, May 19, 2015 at 12:22 PM, Borislav Petkov <bp@alien8.de> wrote:
> > > On Tue, May 19, 2015 at 11:44:41AM -0700, Andy Lutomirski wrote:
> > >> On May 19, 2015 11:13 AM, "Borislav Petkov" <bp@alien8.de> wrote:
> > >> >
> > >> > On Tue, May 19, 2015 at 01:25:59PM -0400, Brian Gerst wrote:
> > >> > > Using strlcpy in this manner could fail if it does larger than byte
> > >> > > copies and they overlap.
> > >> >
> > >> > Why?
> 
> I think this is traditionally handled by specifying that
> the strcpy strings may not overlap, so the suggested
> 
> +	strlcpy(c->x86_model_id, strim(c->x86_model_id), 48);
> 
> isn't good code.
> 
> A temporary intermediate buffer is required.

Or memmove. (duh)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/