Date: Tue, 19 May 2015 22:31:48 +0200
From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Brian Gerst <brgerst@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Igor Mammedov <imammedo@redhat.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup
Message-ID: <20150519203148.GO4641@pd.tnic>
References: <1432050210-32036-1-git-send-email-prarit@redhat.com>
 <CAMzpN2iJr7GVWm5peLxHvUc2geAgWVVqQ-q91SFEBy6LSuJZcA@mail.gmail.com>
 <20150519181334.GM4641@pd.tnic>
 <CALCETrWeQ3McFeyggvV8p+N76gB1-=gYm9SDS4x5RcPb0r_sEg@mail.gmail.com>
 <20150519192206.GN4641@pd.tnic>
 <CALCETrW2YxHeaejGOvpeG2rHwX9sbaw8hQ3xqZ+qRGPtpcuVpQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrW2YxHeaejGOvpeG2rHwX9sbaw8hQ3xqZ+qRGPtpcuVpQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 793
Lines: 28

On Tue, May 19, 2015 at 01:16:23PM -0700, Andy Lutomirski wrote:
> It's not just chunk size; it's the direction.  If the dest starts
> after the source but overlaps it and you copy forwards, then you can
> clobber the end of the source before you read it.  memmove is

Some things should simply be done solely in userspace :-)

> specifically intended to avoid this.
> 
> Would it be possible to just use memmove directly?

Yeah.

Prarit, care to send a v2?

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/