Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbbESUdy (ORCPT ); Tue, 19 May 2015 16:33:54 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47898 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbbESUdx (ORCPT ); Tue, 19 May 2015 16:33:53 -0400 Date: Tue, 19 May 2015 16:33:50 -0400 (EDT) Message-Id: <20150519.163350.407818271127074601.davem@davemloft.net> To: emunson@akamai.com Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] tcp: Return error instead of partial read for saved syn headers From: David Miller In-Reply-To: <1431974158-28288-1-git-send-email-emunson@akamai.com> References: <1431974158-28288-1-git-send-email-emunson@akamai.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 May 2015 13:33:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 17 From: Eric B Munson Date: Mon, 18 May 2015 14:35:58 -0400 > Currently the getsockopt() requesting the cached contents of the syn > packet headers will fail silently if the caller uses a buffer that is > too small to contain the requested data. Rather than fail silently and > discard the headers, getsockopt() should return an error and report the > required size to hold the data. > > Signed-off-by: Eric B Munson Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/