Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbbESVkV (ORCPT ); Tue, 19 May 2015 17:40:21 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35211 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbbESVkS (ORCPT ); Tue, 19 May 2015 17:40:18 -0400 Date: Tue, 19 May 2015 23:40:12 +0200 From: Thierry Reding To: Kevin Hilman Cc: Scot Doyle , Greg Kroah-Hartman , Tomi Valkeinen , Michael Kerrisk , Jiri Slaby , Jean-Christophe Plagniol-Villard , Pavel Machek , Geert Uytterhoeven , lkml , linux-fbdev@vger.kernel.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, Tyler Baker , Olof Johansson , Daniel Stone , Arnd Bergmann Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt Message-ID: <20150519214011.GA27047@ulmo.nvidia.com> References: <20150225094946.GA24627@amd> <20150226220243.GC9935@amd> <20150325111949.GA24230@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3031 Lines: 73 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote: > On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle wrote: > > vt now provides a cursor blink interval via vc_data. Use this > > interval instead of the currently hardcoded 200 msecs. Store it in > > fbcon_ops to avoid locking the console in cursor_timer_handler(). > > > > Signed-off-by: Scot Doyle > > Acked-by: Pavel Machek >=20 > This patch hit next-20150519 in the form of commit 27a4c827c34a > (fbcon: use the cursor blink interval provided by vt) and has caused > boot failure on a handful of ARM platforms when booting a MMC root > filesystem. This error was spotted by the kernelci.org bot on > exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen it on > some tegra platforms too. >=20 > Thierry spotted this commit as a potential cause, and both Daniel and > I have reverted and boot tested on exynos5 and tegra respectively and > the boot panics disappear. FWIW, if I apply the below on top of next-20150519 things seem to be back to normal as well: diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 05b1d1a71ef9..658c34bb9076 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *vc, int mode) return; =20 ops->cur_blink_jiffies =3D msecs_to_jiffies(vc->vc_cur_blink_ms); - fbcon_del_cursor_timer(info); - if (!(vc->vc_cursor_type & 0x10)) + if (vc->vc_cursor_type & 0x10) + fbcon_del_cursor_timer(info); + else fbcon_add_cursor_timer(info); =20 ops->cursor_flash =3D (mode =3D=3D CM_ERASE) ? 0 : 1; --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVW627AAoJEN0jrNd/PrOhy9kQAIZjuDWhk8QSW5fEUMVIsXrZ oXMaXclkr/3OYX4a1xEUlgjDjppGb+T01qws9HGefRNTvY3D2bODDbGA/sEew723 /JvOUCa89EV/bCFKHWcV+i0XGiYxd5JTVE74/9sWQLrp8QbGB99NEXFYtB9quNMw u71c+f8wsRapYSNQcErQwfBsWBW3sRkUSl7HRf0MtfVmSHNnaeFOdDCqquiYL0SL XE3dIZY1MK5j6wgl/Za9AskTipeKoNWN4UX6pGX1QVNUJCN+3Dt1kpoh4ud6tvn9 AlVvtovy76fdaPbVV0DhF+pdLtgVmZcCCU/lTQMjWdxL1ydLBM/OXLtuTdHgepHq NOw+DhoU1ezi9MLAzzL2dvolEkMJL6O5RemzjgV6NUZPi2aB7wc7rHP5yWX2k/Yd jkYM0xHAOm8ra8s7H3WEJLudBK1Klo1x9NHiyZRwMQemxzC/LgRIt5uG5HhhsUCE bEafdIV08sMrixpfvF5vgVxXIhpWAUOJy7UIFw4sD1ExhyzNuFbOERrotP55uYBY miZZgQjBhy1HkLT1FC30SRej4v8HqEGTE71cwh6rJsGyIdWKVDqlONtAjpxtFY+5 pBVV1h0roKk7JNYX0JnKmtXSxZZxRB1ru6EHpiY/o87WO8DcG2yEALdVs1/mOkNp TCE/0wfX2dJBA83LTzaM =NClv -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/