Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbbESVpZ (ORCPT ); Tue, 19 May 2015 17:45:25 -0400 Received: from mail.kernel.org ([198.145.29.136]:41212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbbESVpY (ORCPT ); Tue, 19 May 2015 17:45:24 -0400 MIME-Version: 1.0 In-Reply-To: <20150519214011.GA27047@ulmo.nvidia.com> References: <20150225094946.GA24627@amd> <20150226220243.GC9935@amd> <20150325111949.GA24230@kroah.com> <20150519214011.GA27047@ulmo.nvidia.com> Date: Tue, 19 May 2015 14:45:19 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt From: Kevin Hilman To: Thierry Reding Cc: Kevin Hilman , Scot Doyle , Greg Kroah-Hartman , Tomi Valkeinen , Michael Kerrisk , Jiri Slaby , Jean-Christophe Plagniol-Villard , Pavel Machek , Geert Uytterhoeven , lkml , linux-fbdev@vger.kernel.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, Tyler Baker , Olof Johansson , Daniel Stone , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2246 Lines: 52 On Tue, May 19, 2015 at 2:40 PM, Thierry Reding wrote: > On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote: >> On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle wrote: >> > vt now provides a cursor blink interval via vc_data. Use this >> > interval instead of the currently hardcoded 200 msecs. Store it in >> > fbcon_ops to avoid locking the console in cursor_timer_handler(). >> > >> > Signed-off-by: Scot Doyle >> > Acked-by: Pavel Machek >> >> This patch hit next-20150519 in the form of commit 27a4c827c34a >> (fbcon: use the cursor blink interval provided by vt) and has caused >> boot failure on a handful of ARM platforms when booting a MMC root >> filesystem. This error was spotted by the kernelci.org bot on >> exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen it on >> some tegra platforms too. >> >> Thierry spotted this commit as a potential cause, and both Daniel and >> I have reverted and boot tested on exynos5 and tegra respectively and >> the boot panics disappear. > > FWIW, if I apply the below on top of next-20150519 things seem to be > back to normal as well: > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c > index 05b1d1a71ef9..658c34bb9076 100644 > --- a/drivers/video/console/fbcon.c > +++ b/drivers/video/console/fbcon.c > @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *vc, int mode) > return; > > ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms); > - fbcon_del_cursor_timer(info); > - if (!(vc->vc_cursor_type & 0x10)) > + if (vc->vc_cursor_type & 0x10) > + fbcon_del_cursor_timer(info); > + else > fbcon_add_cursor_timer(info); > > ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1; Applying this on next-20150519 makes my exynos board happily boot again as well. Tested-by: Kevin Hilman Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/