Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbbESXWU (ORCPT ); Tue, 19 May 2015 19:22:20 -0400 Received: from mail-qk0-f175.google.com ([209.85.220.175]:33989 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbbESXWR (ORCPT ); Tue, 19 May 2015 19:22:17 -0400 MIME-Version: 1.0 In-Reply-To: <20150519230532.GV31666@google.com> References: <1430382149-1645-1-git-send-email-jszhang@marvell.com> <20150519230532.GV31666@google.com> From: Bjorn Helgaas Date: Tue, 19 May 2015 18:21:55 -0500 Message-ID: Subject: Re: [PATCH v2 0/2] PCI: designware: improve iATU programming and usage To: Jisheng Zhang Cc: Jingoo Han , Minghuan Lian , Fabrice Gasnier , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm , Pratyush Anand Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1527 Lines: 39 [-cc Mohit, +cc Pratyush] On Tue, May 19, 2015 at 6:05 PM, Bjorn Helgaas wrote: > [+cc Mohit] > > On Thu, Apr 30, 2015 at 04:22:27PM +0800, Jisheng Zhang wrote: >> The outbound iATU programming functions are similar, so PATCH1 consolidates >> them into one. >> >> Most transactions' type are cfg0 and MEM, so current iATU usage is not >> balanced. PATCH2 adopts idea from Minghuan Lian : >> >> http://www.spinics.net/lists/linux-pci/msg40440.html >> >> to change the iATU allocation: iATU0 for cfg and IO, iATU1 for MEM. >> >> Changes since v1: >> - remove outbound iATU programming for IO in dw_pcie_host_init, since it can >> be done by berlin_pcie_{rd|wr}_other_conf() latter. >> - only do outbound iATU programming for MEM if pp->ops->rd_other_conf is not >> set. Thank Fabrice Gasnier to point out "some platforms doesn't have support >> for ATU" >> >> Jisheng Zhang (2): >> PCI: designware: consolidate outbound iATU programming functions >> PCI: designware: use iATU0 for cfg and IO, iATU1 for MEM >> >> drivers/pci/host/pcie-designware.c | 142 ++++++++++++++++--------------------- > > These need acks from Jingoo and/or Mohit. Any opinions? Oops, sorry, forgot about the recent addition of Pratyush. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/