Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033AbbETAeC (ORCPT ); Tue, 19 May 2015 20:34:02 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:13350 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbbETAd7 (ORCPT ); Tue, 19 May 2015 20:33:59 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 19 May 2015 17:31:09 -0700 Message-ID: <555BD66A.5020704@nvidia.com> Date: Wed, 20 May 2015 09:33:46 +0900 From: Alexandre Courbot User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnd Bergmann , David Airlie CC: Ben Skeggs , Thierry Reding , , , Subject: Re: [PATCH] drm/nouveau/platform: add IOMMU dependency References: <2918377.0irYYn09PU@wuerfel> In-Reply-To: <2918377.0irYYn09PU@wuerfel> X-Originating-IP: [10.19.62.24] X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To HKMAIL103.nvidia.com (10.18.16.12) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 20 On 05/19/2015 09:53 PM, Arnd Bergmann wrote: > The recently added iommu code in the nouveau driver fails to build > when the IOMMU support is disabled: > > drivers/gpu/drm/nouveau/nouveau_platform.c: In function 'nouveau_platform_probe_iommu': > drivers/gpu/drm/nouveau/nouveau_platform.c:113:41: error: 'const struct iommu_ops' has no mem > > To avoid the build error, this now adds an explicit dependency on the > IOMMU implementation. I have a local patch to nouveau_platform.c that only calls the IOMMU functions if CONFIG_IOMMU is set. Wouldn't this be more suitable as IOMMU support is only used by Tegra and thus not beneficial for desktop GPUs? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/