Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbbETBC1 (ORCPT ); Tue, 19 May 2015 21:02:27 -0400 Received: from mail.kernel.org ([198.145.29.136]:51764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbbETBCW (ORCPT ); Tue, 19 May 2015 21:02:22 -0400 Date: Wed, 20 May 2015 09:01:51 +0800 From: Shawn Guo To: maitysanchayan@gmail.com Cc: shawn.guo@linaro.org, kernel@pengutronix.de, stefan@agner.ch, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] ARM: vf610: Add SoC bus support for Vybrid Message-ID: <20150520010151.GZ1071@dragon> References: <653ed53ef933a6834c4fd3c90ee47e5fb5c78160.1431928866.git.maitysanchayan@gmail.com> <20150519062413.GR1071@dragon> <20150519094223.GA3194@Sanchayan-Arch.toradex.int> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519094223.GA3194@Sanchayan-Arch.toradex.int> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2047 Lines: 54 On Tue, May 19, 2015 at 03:12:23PM +0530, maitysanchayan@gmail.com wrote: > Hello Shawn, > > On 15-05-19 14:24:13, Shawn Guo wrote: > > On Mon, May 18, 2015 at 11:50:07AM +0530, Sanchayan Maity wrote: > > > Implements SoC bus support to export SoC specific information. Read > > > the unique SoC ID from the Vybrid On Chip One Time Programmable > > > (OCOTP) controller, SoC specific information from the Miscellaneous > > > System Control Module (MSCM), revision from the ROM revision register > > > and expose it via the SoC bus infrastructure. > > > > > > Sample Output: > > > > > > root@vf:/sys/devices/soc0# cat soc_id > > > df63c12a2e2161d4 > > > root@vf:/sys/devices/soc0# cat family > > > Freescale Vybrid VF500 > > > root@vf:/sys/devices/soc0# cat revision > > > 00000013 > > > root@vf:/sys/devices/soc0# cat machine > > > Freescale Vybrid > > > > > > Signed-off-by: Sanchayan Maity > > > --- > > > arch/arm/mach-imx/mach-vf610.c | 81 ++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 81 insertions(+) > > > > > > diff --git a/arch/arm/mach-imx/mach-vf610.c b/arch/arm/mach-imx/mach-vf610.c > > > index 2e7c75b..64c78e4 100644 > > > --- a/arch/arm/mach-imx/mach-vf610.c > > > +++ b/arch/arm/mach-imx/mach-vf610.c > > > @@ -11,6 +11,86 @@ > > > #include > > > #include > > > #include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > > Please group headers together and sort alphabetically. > > Ok. Will fix this and send out a v2. The rest is acceptable? I'm fine with the rest, but would need an ACK from Stefan to apply the patch. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/