Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbbETCk4 (ORCPT ); Tue, 19 May 2015 22:40:56 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:53077 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751261AbbETCkx (ORCPT ); Tue, 19 May 2015 22:40:53 -0400 X-Listener-Flag: 11101 Message-ID: <1432089611.13819.9.camel@mtksdaap41> Subject: Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller From: Eddie Huang To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Wolfram Sang , , "Rob Herring" , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Matthias Brugger , Xudong Chen , Liguo Zhang , , , , , , Sascha Hauer Date: Wed, 20 May 2015 10:40:11 +0800 In-Reply-To: <20150518184300.GB28888@pengutronix.de> References: <1431967209-5261-1-git-send-email-eddie.huang@mediatek.com> <1431967209-5261-3-git-send-email-eddie.huang@mediatek.com> <20150518184300.GB28888@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6268 Lines: 190 Hi Uwe, On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > From: Xudong Chen > > > > The mediatek SoCs have I2C controller that handle I2C transfer. > > This patch include common I2C bus driver. > > This driver is compatible with I2C controller on mt65xx/mt81xx. > > > > Signed-off-by: Xudong Chen > > Signed-off-by: Liguo Zhang > > Signed-off-by: Eddie Huang > > Acked-by: Sascha Hauer > > --- > > drivers/i2c/busses/Kconfig | 9 + > > drivers/i2c/busses/Makefile | 1 + > > drivers/i2c/busses/i2c-mt65xx.c | 675 ++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 685 insertions(+) > > create mode 100644 drivers/i2c/busses/i2c-mt65xx.c > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index 2255af2..14c7266 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -620,6 +620,15 @@ config I2C_MPC > > This driver can also be built as a module. If so, the module > > will be called i2c-mpc. > > > > +config I2C_MT65XX > > + tristate "MediaTek I2C adapter" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + help > > + This selects the MediaTek(R) Integrated Inter Circuit bus driver > > + for MT65xx and MT81xx. > > + If you want to use MediaTek(R) I2C interface, say Y or M here. > > + If unsure, say N. > > + > > config I2C_MV64XXX > > tristate "Marvell mv64xxx I2C Controller" > > depends on MV64X60 || PLAT_ORION || ARCH_SUNXI > > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile > > index cdf941d..abbf422 100644 > > --- a/drivers/i2c/busses/Makefile > > +++ b/drivers/i2c/busses/Makefile > > @@ -60,6 +60,7 @@ obj-$(CONFIG_I2C_JZ4780) += i2c-jz4780.o > > obj-$(CONFIG_I2C_KEMPLD) += i2c-kempld.o > > obj-$(CONFIG_I2C_MESON) += i2c-meson.o > > obj-$(CONFIG_I2C_MPC) += i2c-mpc.o > > +obj-$(CONFIG_I2C_MT65XX) += i2c-mt65xx.o > > obj-$(CONFIG_I2C_MV64XXX) += i2c-mv64xxx.o > > obj-$(CONFIG_I2C_MXS) += i2c-mxs.o > > obj-$(CONFIG_I2C_NOMADIK) += i2c-nomadik.o > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > > new file mode 100644 > > index 0000000..7462f05 > > --- /dev/null > > +++ b/drivers/i2c/busses/i2c-mt65xx.c > > @@ -0,0 +1,675 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: Xudong.chen > s/Xudong.chen/Xudong Chen/ OK > > > +#define I2C_DRV_NAME "mt-i2c" > i2c-mt65xx ? OK, i2c-mt65xx make more sense > > > +} > > + > > +/* calculate i2c port speed */ > It would be nice to summarize the clock frequency settings here. > Something like: > > /* > * The input clock is divided by the value specified in the > * device tree as clock-div. The actual bus speed is then > * derived from this frequency by the following formula: > * .... > > This would make it possible to verify your calculations below. The comment will be: /* * khz: I2C bus clock * hclk: The input clock is divided by the value specified in the * device tree as clock-div * div = (sample_cnt + 1) * (step_cnt + 1) * khz = (hclk / 2) / div * * The calculation is to get div value that let result of * ((hclk / 2) / div) most approach and less than khz */ > > > +static int mtk_i2c_set_speed(struct mtk_i2c *i2c, unsigned int clk_src_in_hz) > > +{ > > + unsigned int khz; > > + unsigned int step_cnt; > > + unsigned int sample_cnt; > > + unsigned int sclk; > > + unsigned int hclk; > > + unsigned int max_step_cnt; > > + unsigned int sample_div = MAX_SAMPLE_CNT_DIV; > > + unsigned int step_div; > > + unsigned int min_div; > > + unsigned int best_mul; > > + unsigned int cnt_mul; > > + > > + if (i2c->speed_hz > MAX_HS_MODE_SPEED) > > + return -EINVAL; > > + else if (i2c->speed_hz > MAX_FS_MODE_SPEED) > > + max_step_cnt = MAX_HS_STEP_CNT_DIV; > > + else > > + max_step_cnt = MAX_STEP_CNT_DIV; > > + > > + step_div = max_step_cnt; > > + /* Find the best combination */ > > + khz = i2c->speed_hz / 1000; > > + hclk = clk_src_in_hz / 1000; > > + min_div = ((hclk >> 1) + khz - 1) / khz; > This is DIV_ROUND_UP(hclk >> 1, khz). OK, it is good to use existed macro. > > > + best_mul = MAX_SAMPLE_CNT_DIV * max_step_cnt; > > + > > + for (sample_cnt = 1; sample_cnt <= MAX_SAMPLE_CNT_DIV; sample_cnt++) { > > + step_cnt = (min_div + sample_cnt - 1) / sample_cnt; > > + cnt_mul = step_cnt * sample_cnt; > > + if (step_cnt > max_step_cnt) > > + continue; > > + > > + if (cnt_mul < best_mul) { > > + best_mul = cnt_mul; > > + sample_div = sample_cnt; > > + step_div = step_cnt; > > + if (best_mul == min_div) > > + break; > > + } > > + } > > + > > + sample_cnt = sample_div; > > + step_cnt = step_div; > > + sclk = hclk / (2 * sample_cnt * step_cnt); > > + if (sclk > khz) { > > + dev_dbg(i2c->dev, "%s mode: unsupported speed (%ldkhz)\n", > > + (i2c->speed_hz > MAX_HS_MODE_SPEED) ? "HS" : "ST/FT", > > + (long int)khz); > > + return -EINVAL; > > + } > > + > > + step_cnt--; > > + sample_cnt--; > > + > > + if (i2c->speed_hz > MAX_FS_MODE_SPEED) { > > + /* Set the hign speed mode register */ > > + i2c->timing_reg = I2C_FS_TIME_INIT_VALUE; > > + i2c->high_speed_reg = I2C_TIME_DEFAULT_VALUE | > > + (sample_cnt & I2C_TIMING_SAMPLE_COUNT_MASK) << 12 | > > + (step_cnt & I2C_TIMING_SAMPLE_COUNT_MASK) << 8; > > + } else { > > + i2c->timing_reg = > > + (sample_cnt & I2C_TIMING_SAMPLE_COUNT_MASK) << 8 | > > + (step_cnt & I2C_TIMING_STEP_DIV_MASK) << 0; > > + /* Disable the high speed transaction */ > > + i2c->high_speed_reg = I2C_TIME_CLR_VALUE; > Can it happen that sample_cnt & I2C_TIMING_SAMPLE_COUNT_MASK != > sample_cnt? If yes, what is the influence on correctness? Same question > for step_cnt. No. it should not happen because we already limit value less than max value. Will remove mask here. Eddie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/