Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbbETCxb (ORCPT ); Tue, 19 May 2015 22:53:31 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:55386 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751345AbbETCx1 (ORCPT ); Tue, 19 May 2015 22:53:27 -0400 X-Listener-Flag: 11101 Message-ID: <1432090402.13819.14.camel@mtksdaap41> Subject: Re: [PATCH v8 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller From: Eddie Huang To: Matthias Brugger CC: Wolfram Sang , srv_heupstream , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Xudong Chen" , Liguo Zhang , , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , , Sascha Hauer Date: Wed, 20 May 2015 10:53:22 +0800 In-Reply-To: References: <1431967209-5261-1-git-send-email-eddie.huang@mediatek.com> <1431967209-5261-4-git-send-email-eddie.huang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 42 Hi Matthias, On Tue, 2015-05-19 at 16:45 +0200, Matthias Brugger wrote: > 2015-05-18 18:40 GMT+02:00 Eddie Huang : > > Add mediatek MT8173 I2C controller driver. Compare to I2C controller > > of earlier mediatek SoC, MT8173 fix write-then-read limitation, and > > also increase message size to 64kb. > > > > Signed-off-by: Xudong Chen > > Signed-off-by: Liguo Zhang > > Signed-off-by: Eddie Huang > > Acked-by: Sascha Hauer > > --- > > drivers/i2c/busses/i2c-mt65xx.c | 94 +++++++++++++++++++++++++++++------------ > > 1 file changed, 67 insertions(+), 27 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > > index 7462f05..1ebbf1a 100644 > > --- a/drivers/i2c/busses/i2c-mt65xx.c > > +++ b/drivers/i2c/busses/i2c-mt65xx.c > > @@ -33,10 +33,13 @@ > > #include > > #include > > > > +#define I2C_RS_TRANSFER (1 << 4) > > As far as I can see, mt6589 and mt8127 don't have this bit defined in > their datasheets (and most probably others neither). > Is it save to write this bit, although it is not implemented? I think it is safe to write this bit. Since other guys may have the same question, I will modify to write I2C_RS_TRANSFER only when this bit exist. Eddie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/