Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbbETDQM (ORCPT ); Tue, 19 May 2015 23:16:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:33037 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbbETDQG (ORCPT ); Tue, 19 May 2015 23:16:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,462,1427785200"; d="scan'208";a="574016216" Message-ID: <555BFC72.3060703@linux.intel.com> Date: Wed, 20 May 2015 11:16:02 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Hanjun Guo , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Len Brown CC: Lv Zheng , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" , linux-arm-kernel@lists.infradead.org Subject: Re: [Patch v3 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core References: <1431593803-5213-1-git-send-email-jiang.liu@linux.intel.com> <1431593803-5213-6-git-send-email-jiang.liu@linux.intel.com> <5559E44B.2010702@linaro.org> In-Reply-To: <5559E44B.2010702@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2563 Lines: 71 On 2015/5/18 21:08, Hanjun Guo wrote: > Hi Jiang, > > On 2015年05月14日 16:56, Jiang Liu wrote: >> Introduce common interface acpi_pci_root_create() and related data >> structures to create PCI root bus for ACPI PCI host bridges. It will >> be used to kill duplicated arch specific code for IA64 and x86. It may >> also help ARM64 in future. > > As I commented in previous version, this patch will introduce > compile error on ACPI enabled ARM64 kernel because struct > pci_controller is not defined for ARM64, so how about adding > the following patch before this patch, or squash to this one, > does it make sense? Hi Hanjun, Thanks for fixing this building issue for ARM64. The patch is really what I want:). Will merge it into next version. With this patch applied, are there any other issues from ARM64 side? Thanks! Gerry > > From 11d0e98154e681e75936698208398cb4dcd73632 Mon Sep 17 00:00:00 2001 > From: Hanjun Guo > Date: Mon, 18 May 2015 19:41:56 +0800 > Subject: [PATCH] ARM64 / PCI: introduce struct pci_controller for ACPI > > ARM64 ACPI based PCI host bridge init needs a arch dependent > struct pci_controller to accommodate common PCI host bridge > code which is introduced later, or it will lead to compile > errors on ARM64. > > Signed-off-by: Hanjun Guo > CC: Liviu Dudau > CC: Will Deacon > CC: Catalin Marinas > CC: Lorenzo Pieralisi > CC: Arnd Bergmann > --- > arch/arm64/include/asm/pci.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > index b008a72..7088495 100644 > --- a/arch/arm64/include/asm/pci.h > +++ b/arch/arm64/include/asm/pci.h > @@ -10,6 +10,16 @@ > #include > #include > > +struct acpi_device; > + > +struct pci_controller { > +#ifdef CONFIG_ACPI > + struct acpi_device *companion; /* ACPI companion device */ > +#endif > + int segment; /* PCI domain */ > + int node; /* NUMA node */ > +}; > + > #define PCIBIOS_MIN_IO 0x1000 > #define PCIBIOS_MIN_MEM 0 > > > Thanks > Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/