Message-id: <555BFE78.2000503@samsung.com>
Date: Wed, 20 May 2015 12:24:40 +0900
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
MIME-version: 1.0
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Chanwoo Choi <cwchoi00@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        gg@slimlogic.co.uk, Kishon Vijay Abraham I <kishon@ti.com>,
        jaewon02.kim@samsung.com, Roger Quadros <rogerq@ti.com>,
        "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
        george.cherian@ti.com, Felipe Balbi <balbi@ti.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 1/2] extcon: Use the unique id for external connector
 instead of string
References: <1431700278-30465-1-git-send-email-cw00.choi@samsung.com>
 <1431700278-30465-2-git-send-email-cw00.choi@samsung.com>
 <CAJKOXPfP0j9g-UkDPu26XjpKgRwMrdL6p99TykVQUHk6k0VDsg@mail.gmail.com>
 <CAGTfZH0ZHJGMM1OwEQXrA5NdJhK-iWdzxwFBDx+q62H3rdFsog@mail.gmail.com>
 <555B2C56.8080105@samsung.com>
In-reply-to: <555B2C56.8080105@samsung.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1837
Lines: 41

On 19.05.2015 21:28, Chanwoo Choi wrote:
> Hi Krzysztof,
> 
>>>> +
>>>> +       if (i == edev->max_supported)
>>>> +               return -EINVAL;
>>>>
>>>>         if (index < 0 || (edev->max_supported && edev->max_supported <= index))
>>>>                 return -EINVAL;
>>>> @@ -605,7 +644,7 @@ static void dummy_sysfs_dev_release(struct device *dev)
>>>>   *
>>>>   * Return the pointer of extcon device if success or ERR_PTR(err) if fail
>>>>   */
>>>> -struct extcon_dev *extcon_dev_allocate(const char **supported_cable)
>>>> +struct extcon_dev *extcon_dev_allocate(const enum extcon *supported_cable)
>>>
>>> I think you also have to update the documentation. At least for
>>> {devm}_extcon_dev_allocate but maybe in other places too. Previously
>>> the documentation states that supported_cable is an array of strings.
>>> Additionally AFAIU now it must end with EXTCON_NONE. This
>>> sentinel-like info must be clearly documented.
> 
> As you commented, extcon must need to document the update and usage method of extcon core.
> The mainline kernel includes only the 'Documentation/extcon/porting-android-switch-class'.
> Namely, the mainline kernel have not included the document showing the usage method of extcon core.

I mean documentation for the function. The kerneldoc above functions says:

* @supported_cable:    Array of supported cable names ending with NULL.
*                      If supported_cable is NULL, cable name related APIs
*                      are disabled.

AFAIU now the supported cable must end with EXTCON_NONE. Is it correct?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/