Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbbETDkH (ORCPT ); Tue, 19 May 2015 23:40:07 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:33319 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbbETDkD convert rfc822-to-8bit (ORCPT ); Tue, 19 May 2015 23:40:03 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Thierry Reding , "Benson Leung" , "Rhyland Klein" , "Peter De Schrijver" From: Michael Turquette In-Reply-To: <1431012219-28469-1-git-send-email-thierry.reding@gmail.com> Cc: "Stephen Boyd" , "Stephen Warren" , "Alexandre Courbot" , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1430919815-22380-1-git-send-email-thierry.reding@gmail.com> <1431012219-28469-1-git-send-email-thierry.reding@gmail.com> Message-ID: <20150520033956.9817.55602@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH v2] clk: tegra: Update struct tegra_clk_pll_params kerneldoc Date: Tue, 19 May 2015 20:39:56 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2927 Lines: 71 Quoting Thierry Reding (2015-05-07 08:23:39) > From: Thierry Reding > > Benson Leung pointed out that the kerneldoc for this structure has > become stale. Update the field descriptions to match the structure > content. > > Reported-by: Benson Leung > Acked-by: Rhyland Klein > Signed-off-by: Thierry Reding Looks good to me. Regards, Mike > --- > Changes in v2: > - document max_p and pdiv_tohw fields > > drivers/clk/tegra/clk.h | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h > index f3782dedbdfb..b76b786e15f6 100644 > --- a/drivers/clk/tegra/clk.h > +++ b/drivers/clk/tegra/clk.h > @@ -157,7 +157,7 @@ struct div_nmp { > }; > > /** > - * struct clk_pll_params - PLL parameters > + * struct tegra_clk_pll_params - PLL parameters > * > * @input_min: Minimum input frequency > * @input_max: Maximum input frequency > @@ -168,12 +168,24 @@ struct div_nmp { > * @base_reg: PLL base reg offset > * @misc_reg: PLL misc reg offset > * @lock_reg: PLL lock reg offset > - * @lock_bit_idx: Bit index for PLL lock status > + * @lock_mask: Bitmask for PLL lock status > * @lock_enable_bit_idx: Bit index to enable PLL lock > + * @iddq_reg: PLL IDDQ register offset > + * @iddq_bit_idx: Bit index to enable PLL IDDQ > + * @aux_reg: AUX register offset > + * @dyn_ramp_reg: Dynamic ramp control register offset > + * @ext_misc_reg: Miscellaneous control register offsets > + * @pmc_divnm_reg: n, m divider PMC override register offset (PLLM) > + * @pmc_divp_reg: p divider PMC override register offset (PLLM) > + * @flags: PLL flags > + * @stepa_shift: Dynamic ramp step A field shift > + * @stepb_shift: Dynamic ramp step B field shift > * @lock_delay: Delay in us if PLL lock is not used > + * @max_p: maximum value for the p divider > + * @pdiv_tohw: mapping of p divider to register values > + * @div_nmp: offsets and widths on n, m and p fields > * @freq_table: array of frequencies supported by PLL > * @fixed_rate: PLL rate if it is fixed > - * @flags: PLL flags > * > * Flags: > * TEGRA_PLL_USE_LOCK - This flag indicated to use lock bits for > -- > 2.3.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/