Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752387AbbETDsv (ORCPT ); Tue, 19 May 2015 23:48:51 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:17391 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbETDss (ORCPT ); Tue, 19 May 2015 23:48:48 -0400 Message-ID: <555C03F7.4040206@huawei.com> Date: Wed, 20 May 2015 11:48:07 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Alexei Starovoitov , , , , , , , , , , CC: , , Subject: Re: [RFC PATCH v3 06/37] bpf tools: Introduce 'bpf' library to tools References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-7-git-send-email-wangnan0@huawei.com> <555A22DB.5040200@plumgrid.com> In-Reply-To: <555A22DB.5040200@plumgrid.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 38 在 2015/5/19 1:35, Alexei Starovoitov 写道: > On 5/17/15 3:56 AM, Wang Nan wrote: >> This is the first patch of libbpf. The goal of libbpf is to create a >> standard way for accessing eBPF object files. This patch creates >> Makefile and Build for it, allows 'make' to build libbpf.a and >> libbpf.so, 'make install' to put them into proper directories. >> Most part of Makefile is borrowed from traceevent. Before building, >> it checks the existance of libelf in Makefile, and deny to build if >> not found. Instead of throw an error if libelf not found, the error >> raises in a phony target "elfdep". This design is to ensure >> 'make clean' still workable even if libelf is not found. >> >> Signed-off-by: Wang Nan >> --- > ... >> + >> +# Version of eBPF elf file >> +FILE_VERSION = 1 > > what that comment suppose to mean? The format of eBPF objects can be improved in futher. A version number here is the precaution of backward compatibility. However this patch doesn't utilize it. I'd like to append a 'format' section into eBPF object format to let libbpf know the version of the object. What do you think? Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/