Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbbETFGC (ORCPT ); Wed, 20 May 2015 01:06:02 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:33319 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbETFF7 convert rfc822-to-8bit (ORCPT ); Wed, 20 May 2015 01:05:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <1432036279-6318-1-git-send-email-k.kozlowski.k@gmail.com> <1432036279-6318-2-git-send-email-k.kozlowski.k@gmail.com> From: Alexandre Courbot Date: Wed, 20 May 2015 14:05:38 +0900 Message-ID: Subject: Re: [RESEND PATCH 2/2] ARM: dts: tegra: Use labels for overriding nodes in Tegra114 boards To: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= Cc: Stephen Warren , Thierry Reding , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 29 On Wed, May 20, 2015 at 2:03 PM, Krzysztof Kozłowski wrote: > 2015-05-20 13:05 GMT+09:00 Alexandre Courbot : >> On Tue, May 19, 2015 at 8:51 PM, Krzysztof Kozlowski >> wrote: >>> Usage of labels instead of full paths reduces possible mistakes when >>> overriding nodes. >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> Indentation seems to be off by one tab in the added code (hence the >> huge size of this patch ; most lines should not change), can you >> check? > > It is correct. This change in indentation is an effect of moving nodes > out of first bracket ("\ {"). That is the convention. > > It us up to you guys if this is worth the effort. For exynos we use > label-convention and now I am converting old DTS to it. I think the > label-convention is less error-prone when extending or overriding > nodes. Also it removes duplicated addresses. I don't really have a strong opinion on this - Stephen and Thierry have worked with DT much more, let's see what they think... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/