Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbbETGem (ORCPT ); Wed, 20 May 2015 02:34:42 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:33509 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbETGel (ORCPT ); Wed, 20 May 2015 02:34:41 -0400 Date: Wed, 20 May 2015 08:34:35 +0200 From: Ingo Molnar To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Andy Lutomirski , Borislav Petkov , Denys Vlasenko , Dave Hansen , Igor Mammedov , Fenghua Yu , Brian Gerst Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup Message-ID: <20150520063435.GA24430@gmail.com> References: <1432050210-32036-1-git-send-email-prarit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432050210-32036-1-git-send-email-prarit@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1748 Lines: 58 * Prarit Bhargava wrote: > arch/x86/kernel/cpu/common.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) So I saw this title: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup ... and in an early morning deconcentrated state was skipped the changelog and was looking for a whitespace coding style cleanup: > @@ -431,18 +430,10 @@ static void get_model_name(struct cpuinfo_x86 *c) > c->x86_model_id[48] = 0; > > /* > - * Intel chips right-justify this string for some dumb reason; > - * undo that brain damage: > + * Remove leading whitespace on Intel processors and trailing > + * whitespace on AMD processors. > */ > - p = q = &c->x86_model_id[0]; > - while (*p == ' ') > - p++; > - if (p != q) { > - while (*p) > - *q++ = *p++; > - while (q <= &c->x86_model_id[48]) > - *q++ = '\0'; /* Zero-pad the rest */ > - } > + strlcpy(c->x86_model_id, strim(c->x86_model_id), 48); > } Which this clearly isnt! Fortunately before complaining about that I read the changelog as well, and realized that the 'whitespace cleanup' is done to /proc/cpuinfo ABI output. Could you please make the title less ambiguous, so that sleepy kernel developers get the right idea what the patch looks like, from the title alone? Git shortlogs will vastly improve as well. Something like: [PATCH] x86/cpu: Strip leading and trailing spaces from the /proc/cpuinfo CPU model field ... or so would work very well for me! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/