Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 22 Jan 2003 14:47:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 22 Jan 2003 14:47:56 -0500 Received: from smtpzilla1.xs4all.nl ([194.109.127.137]:45578 "EHLO smtpzilla1.xs4all.nl") by vger.kernel.org with ESMTP id ; Wed, 22 Jan 2003 14:47:55 -0500 Message-ID: <3E2EF3FB.4335D3F5@linux-m68k.org> Date: Wed, 22 Jan 2003 20:41:47 +0100 From: Roman Zippel X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.4.20 i686) X-Accept-Language: en MIME-Version: 1.0 To: Kai Germaschewski CC: Mikael Pettersson , Ingo Oeser , linux-kernel@vger.kernel.org, rusty@rustcorp.com.au Subject: Re: kernel param and KBUILD_MODNAME name-munging mess References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, Kai Germaschewski wrote: > KBUILD_BASENAME needs to be an un-stringified symbol following > certain conventions to make it possible to use it e.g. in > include/linux/spinlock.h, that's why '-' and ',' are escaped to '_'. > > However, for all I can tell, this is not true for KBUILD_MODNAME, since > that seems to be only used for constructing an actual string, which of > course can contain all kinds of characters. So I think using the first > approach would be somewhat nicer, as it gets rid of the unintuitive > "ide-cd" -> "ide_cd" munging on the kernel command line. It might be useful later to build a list of builtin modules. Currently we do nothing if a builtin module fails to initialize, but we should disable dependent modules and remove the exported symbols. Maybe it's better to provide the module name both as label and string. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/