Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbETHHs (ORCPT ); Wed, 20 May 2015 03:07:48 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:64874 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbbETHHr (ORCPT ); Wed, 20 May 2015 03:07:47 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Alexandre Courbot , Ben Skeggs , David Airlie , gnurou@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding Subject: Re: [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU Date: Wed, 20 May 2015 09:07:04 +0200 Message-ID: <3919309.jIrkBUJG1x@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1432102224-15169-1-git-send-email-acourbot@nvidia.com> References: <555BD66A.5020704@nvidia.com> <1432102224-15169-1-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:PeM7WWPqu/2aESv9ivwRYe0oyyi5d8Mm8G30XypWVDELAknChI4 kJuis7ZYDaki7BoJVBsbKJxmTc8P23XtZS2K1HpkXVKJ31rvXq7p6Jg8glvFmf0Rq3OVzYE 1FJf2WRVhyZcGETgNDxOudMUUoo+dOM5vBVesU4Lj05SKqNgNy7YnbBeY0j8KHjY5vge5xO byDWftxEsovZUQxpnou/w== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 21 On Wednesday 20 May 2015 15:10:24 Alexandre Courbot wrote: > The lack of IOMMU API support can make nouveau_platform_probe_iommu() > fail to compile because struct iommu_ops is then empty. Fix this by > skipping IOMMU probe in that case - lack of IOMMU on platform devices > is sub-optimal, but is not an error. > > Signed-off-by: Alexandre Courbot > --- > This is an alternative to https://lkml.org/lkml/2015/5/19/484. Most users > of Nouveau do not care about IOMMU support, so we should not impose that > option on them. > Yes, good idea. Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/