Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbbETHTH (ORCPT ); Wed, 20 May 2015 03:19:07 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:55331 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbbETHTE (ORCPT ); Wed, 20 May 2015 03:19:04 -0400 Message-ID: <555C3546.5070808@kapsi.fi> Date: Wed, 20 May 2015 10:18:30 +0300 From: Mikko Perttunen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Sascha Hauer , linux-pm@vger.kernel.org CC: Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Stephen Warren , kernel@pengutronix.de, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Brian Norris Subject: Re: [PATCH 05/15] thermal: Add comment explaining test for critical temperature References: <1431507163-19933-1-git-send-email-s.hauer@pengutronix.de> <1431507163-19933-6-git-send-email-s.hauer@pengutronix.de> In-Reply-To: <1431507163-19933-6-git-send-email-s.hauer@pengutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:708:30:12d0:beee:7bff:fe5b:f272 X-SA-Exim-Mail-From: mikko.perttunen@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 34 On 05/13/15 11:52, Sascha Hauer wrote: > The code testing if a temperature should be emulated or not is > not obvious. Add a comment explaining why this test is done. > > Signed-off-by: Sascha Hauer > --- > drivers/thermal/thermal_core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 3e0fe55..e204deb 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -435,6 +435,11 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp) > } > } > > + /* > + * Only allow emulating a temperature when the real temperature > + * is below the critical temperature so that the emulation code > + * cannot hide critical conditions. > + */ > if (!ret && *temp < crit_temp) > *temp = tz->emul_temperature; > } > Reviewed-by: Mikko Perttunen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/