Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbbETHZU (ORCPT ); Wed, 20 May 2015 03:25:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47242 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbbETHZR (ORCPT ); Wed, 20 May 2015 03:25:17 -0400 Message-ID: <555C36D1.4060003@suse.cz> Date: Wed, 20 May 2015 15:25:05 +0800 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Rusty Russell , Joe Perches , One Thousand Gnomes CC: David Woodhouse , LKML , Quentin Casasnovas , Andreas Schwab Subject: Re: mod_devicetable: Make dmi_strmatch.substr const char * References: <1431994055.2870.102.camel@perches.com> <1432018018.3277.22.camel@infradead.org> <20150519165630.169c64d3@lxorguk.ukuu.org.uk> <1432063162.2870.199.camel@perches.com> <878ucjhlmg.fsf@rustcorp.com.au> In-Reply-To: <878ucjhlmg.fsf@rustcorp.com.au> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 34 Dne 20.5.2015 v 13:19 Rusty Russell napsal(a): > Joe Perches writes: >> On Tue, 2015-05-19 at 16:56 +0100, One Thousand Gnomes wrote: >>> On Tue, 19 May 2015 07:46:58 +0100 David Woodhouse wrote: >>>> On Mon, 2015-05-18 at 17:07 -0700, Joe Perches wrote: >>>>> changed dmi_strmatch.substr from char * to char[79]; >>>>> >>>>> Changing it back to const char * would shrink an x86-64 >>>>> defconfig more than 100KB. As David already pointed out, this breaks modpost. Also, what makes the dmi tables special? We use character arrays in other tables as well, to make them self-contained for modpost. > But it seems the file2alias code was rewritten in 2013 by Andreas Schwab > , and SOB Michal Marek , without > going through me. Annoying, since they had to hack it because people > screwed up mod_devicetable.h with arch-dependent layouts :( Oh, sorry about it. > I guess that means Michal is the maintainer now, so I've CC'd him. OK, fine, I can carry modpost patches in kbuid.git. I think I have merged a few more besides the file2alias rework. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/