Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbbETHiZ (ORCPT ); Wed, 20 May 2015 03:38:25 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:42175 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbETHiX (ORCPT ); Wed, 20 May 2015 03:38:23 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 20 May 2015 09:36:38 +0200 From: Stefan Agner To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Sanchayan Maity , shawn.guo@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2 2/2] ARM: vf610: Add SoC bus support for Vybrid In-Reply-To: <9691074.oWRy1bscbz@wuerfel> References: <27733a88b73adb7000205e020bafdb6f7ebe1843.1432099651.git.maitysanchayan@gmail.com> <9691074.oWRy1bscbz@wuerfel> Message-ID: <61cec15fe896133ee6e102b0242fb43d@agner.ch> User-Agent: Roundcube Webmail/1.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 39 On 2015-05-20 09:12, Arnd Bergmann wrote: > On Wednesday 20 May 2015 11:06:52 Sanchayan Maity wrote: >> Implements SoC bus support to export SoC specific information. Read >> the unique SoC ID from the Vybrid On Chip One Time Programmable >> (OCOTP) controller, SoC specific information from the Miscellaneous >> System Control Module (MSCM), revision from the ROM revision register >> and expose it via the SoC bus infrastructure. >> >> Sample Output: >> >> root@vf:/sys/devices/soc0# cat soc_id >> df63c12a2e2161d4 >> root@vf:/sys/devices/soc0# cat family >> Freescale Vybrid VF500 >> root@vf:/sys/devices/soc0# cat revision >> 00000013 >> root@vf:/sys/devices/soc0# cat machine >> Freescale Vybrid >> > > I would prefer to see this as a driver in drivers/soc that registers > to a platform device. Is there any DT node that would be a reasonable > device to bind to? Hm, what is a viable device? Probably the most SoC specific device in the SoC? Currently, all three devices we read from do have a vf610-something compatible string, hence would be SoC specific (ocotp, ocrom and mscm-cpucfg). Probably the last is the most SoC specific... But somehow bind to just a random device sounds wrong to me. Couldn't we add a more specific compatible string to the soc node and bind to that? -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/