Message-ID: <555C4301.3070806@lab.ntt.co.jp>
Date: Wed, 20 May 2015 17:17:05 +0900
From: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
CC: Xiao Guangrong <guangrong.xiao@linux.intel.com>, rkrcmar@redhat.com
Subject: Re: [PATCH 3/9] KVM: const-ify uses of struct kvm_userspace_memory_region
References: <1432056313-36100-1-git-send-email-pbonzini@redhat.com> <1432056313-36100-4-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1432056313-36100-4-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 33

On 2015/05/20 2:25, Paolo Bonzini wrote:
> Architecture-specific helpers are not supposed to muck with
> struct kvm_userspace_memory_region contents.  Add const to
> enforce this.

Nice, this is what I wanted to do, but could not do, when I
cleaned up these functions a few years ago.

> 
> In order to eliminate the only write in __kvm_set_memory_region,
> the cleaning of deleted slots is pulled up from update_memslots
> to __kvm_set_memory_region.

-	if (!npages)
-		mem->flags &= ~KVM_MEM_LOG_DIRTY_PAGES;

Especially, removing this hard-to-understand lines is really
nice.

> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>


	Takuya


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/