Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790AbbETIWp (ORCPT ); Wed, 20 May 2015 04:22:45 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:56865 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbbETIWi (ORCPT ); Wed, 20 May 2015 04:22:38 -0400 Message-ID: <1432110155.21715.45.camel@x220> Subject: Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component From: Paul Bolle To: Yaniv Gardi Cc: James.Bottomley@HansenPartnership.com, kishon@ti.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, gbroner@codeaurora.org, dovl@codeaurora.org, Vinayak Holikatti , "James E.J. Bottomley" Date: Wed, 20 May 2015 10:22:35 +0200 In-Reply-To: <1432106479.21715.33.camel@x220> References: <1432043231-31102-1-git-send-email-ygardi@codeaurora.org> <1432043231-31102-4-git-send-email-ygardi@codeaurora.org> <1432106479.21715.33.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 24 On Wed, 2015-05-20 at 09:21 +0200, Paul Bolle wrote: > As far as I can see, in next-20150519, drivers/scsi/ufs/ufs-qcom.c lacks > the required module specific boilerplate for this to be useful. Is that > boilerplate added in another series? I need to rephrase this. Let me try again. As far as I can see, in next-20150519, drivers/scsi/ufs/ufs-qcom.c lacks a MODULE_LICENSE() macro. Without that macro loading the module should trigger a warning and taint the kernel, right? By the way, as far as I can see, this (new) module can only be loaded manually (or via scripts). Is that what people want? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/